Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scrollable field list navigation sidebar in new generate UI #2144

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkapal
Copy link
Contributor

@mkapal mkapal commented May 22, 2024

When using the New Generate UI (Preview), the left sidebar containing option navigation is now scrollable if the list height overflows the available vertical space.

Demo (IntelliJ):

Screen.Recording.2024-05-22.at.21.19.42.mov

Copy link

nx-cloud bot commented May 22, 2024

@mkapal mkapal force-pushed the feature/scrollable-field-list-option-nav branch from 5f3b4ff to 10c338d Compare May 22, 2024 19:36
@mkapal mkapal marked this pull request as draft May 22, 2024 19:39
@mkapal
Copy link
Contributor Author

mkapal commented May 22, 2024

This is still not working correctly in VS Code. The scrollbar doesn't appear all the time when it should:

Screen.Recording.2024-05-22.at.21.44.59.mov

@MaxKless
Copy link
Collaborator

MaxKless commented Jun 6, 2024

do you need any help here? Is there something I can do? :)

@mkapal
Copy link
Contributor Author

mkapal commented Jun 6, 2024

Sure, can you please have a look how to make it work in VS Code too?

@MaxKless
Copy link
Collaborator

I'll look into it as soon as I have the time :)

@MaxKless
Copy link
Collaborator

Hey! Sorry I haven't gotten around to this yet as it's not super high priority. Scrollbars in web views are a bit tricky but I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants