Merge pull request #96 from nrwl/steve/chore/add-more-configuration

nrwl · Feb 29, 2024 · db466db · db466db
2 parents 7750567 + cc8c266
commit db466db
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 7 deletions.
diff --git a/charts/nx-agents/Chart.yaml b/charts/nx-agents/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: nx-agents
 description: Nx Cloud Agents Helm Chart
 type: application
-version: 1.0.0-rc.2
+version: 1.0.0-rc.3
 maintainers:
   - name: nx
     url: "https://nx.app/"

diff --git a/charts/nx-agents/templates/deployment.yaml b/charts/nx-agents/templates/deployment.yaml
@@ -101,5 +101,5 @@ spec:
           {{- end }}
           {{- end }}
           {{- end }}
-      serviceAccountName: nx-cloud-workflow-controller
+      serviceAccountName: {{ .Values.serviceAccounts.controller.name }}
       terminationGracePeriodSeconds: 10
diff --git a/charts/nx-agents/templates/rolebinding.yaml b/charts/nx-agents/templates/rolebinding.yaml
@@ -12,5 +12,21 @@ roleRef:
   name: nx-cloud-workflow-controller-role
 subjects:
   - kind: ServiceAccount
-    name: nx-cloud-workflow-controller
-    namespace: {{ .Values.global.namespace }}
+    name: {{ .Values.serviceAccounts.controller.name }}
+    namespace: {{ .Values.global.namespace }}
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: RoleBinding
+metadata:
+  labels:
+    {{- include "nxCloud.app.labels" . | indent 4 }}
+  name: nx-cloud-workflow-runner-rolebinding
+  namespace: {{ .Values.global.namespace }}
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: Role
+  name: nx-cloud-workflow-runner-role
+subjects:
+- kind: ServiceAccount
+  name: {{ .Values.serviceAccounts.runner.name }}
+  namespace: {{ .Values.global.namespace }}
diff --git a/charts/nx-agents/templates/roles.yaml b/charts/nx-agents/templates/roles.yaml
@@ -59,4 +59,18 @@ rules:
   resources:
     - jobs/status
   verbs:
-    - get
+    - get
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: Role
+metadata:
+  name: nx-cloud-workflow-runner-role
+  namespace: {{ .Values.global.namespace }}
+rules:
+- apiGroups:
+  - ""
+  resources:
+  - services
+  verbs:
+  - get
+  - list
diff --git a/charts/nx-agents/templates/serviceaccounts.yaml b/charts/nx-agents/templates/serviceaccounts.yaml
@@ -2,7 +2,9 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: nx-cloud-workflow-runner
+  labels:
+    {{- include "nxCloud.app.labels" . | indent 4 }}
+  name: {{ .Values.serviceAccounts.runner.name }}
   namespace: {{ .Values.global.namespace }}
   {{- if .Values.serviceAccounts.runner.annotations }}
   annotations:
@@ -15,7 +17,7 @@ kind: ServiceAccount
 metadata:
   labels:
     {{- include "nxCloud.app.labels" . | indent 4 }}
-  name: nx-cloud-workflow-controller
+  name: {{ .Values.serviceAccounts.controller.name }}
   namespace: {{ .Values.global.namespace }}
   {{- if .Values.serviceAccounts.controller.annotations }}
   annotations:

diff --git a/charts/nx-agents/values.yaml b/charts/nx-agents/values.yaml
@@ -10,8 +10,10 @@ naming:
 
 serviceAccounts:
   controller:
+    name: nx-cloud-workflow-controller
     annotations: {}
   runner:
+    name: nx-cloud-workflow-runner
     annotations: {}
 
 controller: