feat(dashboard): more precise calculation of step conditions #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX,
tatarco,
djabarovgeorge and
desiprisg
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
commented
Jan 30, 2025
Comment on lines
-88
to
-94
| const conditionsCount = useMemo(() => { | ||
| if (!data.controlValues?.skip) return 0; | ||
|
|
||
| const query = parseJsonLogic(data.controlValues.skip as RQBJsonLogic); | ||
|
|
||
| return query.rules.length; | ||
| }, [data.controlValues]); |
There was a problem hiding this comment.
moved to reusable hook
|
|
||
| const query = parseJsonLogic(jsonLogic); | ||
|
|
||
| return countRules(query); |
There was a problem hiding this comment.
added logic to calculate the nested conditions
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BiswaViraj
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Updates:
Skip ConditionstoStep Conditionsmerge conflictScreenshots
Screen.Recording.2025-01-30.at.18.25.46.mov