Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-GO-1] API 🚀: Validate MX Record Setup for Inbound Parse Functionality #22

Merged

Conversation

NonsoAmadi10
Copy link
Contributor

What does this PR do?

How should this be tested manually?

  • Run the following:
package main

import (
	"context"
	"fmt"
	novu "github.com/novuhq/go-novu/lib"
	"log"
)

func main() {
	apiKey := "<REPLACE_WITH_YOUR_API_KEY>"
        ctx := context.Background()
        
        novuClient := novu.NewAPIClient(apiKey, &novu.Config{})
        resp, err := novuClient.InboundParser.Get(ctx)
        if err != nil {
		log.Fatal("novu error", err.Error())
		return
	}

	fmt.Println(resp.Data.MxRecordConfigured)
	
	}

Any Background Context?

  • N/A

@NonsoAmadi10
Copy link
Contributor Author

@unicodeveloper and @prajjwaldimri please here is my contribution, I appreciate any feedback

@unicodeveloper
Copy link
Contributor

@unicodeveloper and @prajjwaldimri please here is my contribution, I appreciate any feedback

Thanks for your contribution. Merging this in now. @NonsoAmadi10

@unicodeveloper
Copy link
Contributor

unicodeveloper commented Sep 5, 2023

@NonsoAmadi10 I had to revert this #27

Please check the code & test again, there is a nil pointer dereference error. See here for reference https://github.com/novuhq/go-novu/actions/runs/6080648872/job/16494937616
Screenshot 2023-09-05 at 06 48 18

@NonsoAmadi10
Copy link
Contributor Author

Hello @unicodeveloper , thank you very much for the feedback. I will implement it and circle back to you.

@unicodeveloper
Copy link
Contributor

@NonsoAmadi10 Please any update here?

@NonsoAmadi10
Copy link
Contributor Author

@NonsoAmadi10 Please any update here?

Yes please, I have raised a new PR for this issue here #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants