Partial python3 support #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported only code, which supports python 2.7 Several modules looks like should be just removed instead of fixing Fixed: * print usage * file operations (`file` is not supported anymore) * `from math import *` * mix of tabs and spaces
pyx code not changed and makefile not adopted
* fix print and file operations * md5 is not available in py3 -> use hashlib.md5
|
3 CI builds was failed due to some error in PIP (tests was not started) |
* This files are not compatible with python2.4 and was never updated. Search not shown usage of it.
division in python3 differs from python2 without __future__ `sys.stdout.write` in python3 do not accept bytes and `struct.pack` produce bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #472 #501
Fixed:
fileis not supported anymore)from math import *md5import for python 3: usehashlib.md5Exceptionshould be used)reprfrom __future__ import divisionand//for integer division