Player Odds Endpoint #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
reviewed
May 3, 2023
There was a problem hiding this comment.
Overall looks good and I used curl to test the API and returned values are as expected:
curl http://localhost:8081/api/guesses/odds
[["alice",0.6687994],["steve",0.011756565],["bob",0.31944403]]After the suggested fixes you should also cargo fmt and squash the commits into one commit.
| @@ -4,6 +4,10 @@ pub use serde; | |||
| pub use serde_json; | |||
| pub use serde_with; | |||
|
|
|||
| const NONCE_MIN: u32 = 0; | |||
There was a problem hiding this comment.
I don't think we need constants for these, can create a type alias for u32:
Suggested change
| const NONCE_MIN: u32 = 0; | |
| type Nonce = u32; |
And replace: NONCE_MIN with Nonce::MIN, NONCE_MAX with Nonce::MAX, and NONCE_SET_SPACE is always going to be Nonce::MAX.
| @@ -212,6 +214,13 @@ async fn get_target_nonce(Extension(state): Extension<Arc<State>>) -> Result<Str | |||
| Ok(String::default()) | |||
| } | |||
|
|
|||
| async fn get_guess_probabalities(Extension(state): Extension<Arc<State>>) -> Result<Json<Vec<(String, f32)>>, Error> { | |||
There was a problem hiding this comment.
little spelling typo:
Suggested change
| async fn get_guess_probabalities(Extension(state): Extension<Arc<State>>) -> Result<Json<Vec<(String, f32)>>, Error> { | |
| async fn get_guess_probabilities(Extension(state): Extension<Arc<State>>) -> Result<Json<Vec<(String, f32)>>, Error> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes an endpoint that returns the probability of each guess being selected from a uniformly distributed nonce.