DELETE unfollow profile #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 22, 2023 10:23
nomisRev
reviewed
Oct 28, 2023
There was a problem hiding this comment.
Looking great @pabloaguilarmartinez 🙌 Thanks for your interest in this project, and your time for the contribution.
2 small nits:
- The original
deletequery was quite bad for the requirements, so I updated the query. This simplifies some of the code. - Thanks to type-safe routing in Ktor we get safe access to any parameters and queries.
Besides that looking perfect 👏
Sorry for the delay in reviewing, I was sick this week.
Happy hacktoberfest 👻
…on and removing either because this query can only fail unexpectedly
…fe routes to safely access a non-null username value
|
Looks prefect! Thank you @pabloaguilarmartinez 👏 👏 And thank you for your interest in the project, and taking your time to contribute to this project 🙌 |
|
Thanks to you @nomisRev , it is a really good initiative for hacktoberfest. I enjoyed it a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the following issue #156
Missing POST to follow user just to check if the relationship is updated when unfollow. With that we may have to refactor.