Adding the default README, if any #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (err) return done(err) | ||
| if (!repo) return done() | ||
| async.parallel({ | ||
| getRepository : function (callbackFn) { |
There was a problem hiding this comment.
callback functions are usually written as cb or done - best to follow the convention of existing code in the repo. Also goes for putting spaces after var name, e.g. 'foo : bar', go with whatever the existing code uses (this stuff should be caught by a linter)
There was a problem hiding this comment.
Updated - will commit tomorrow - to follow the current code convention.
There was a problem hiding this comment.
npm run test npm run lint will ensure the code follow is the correct convention for you. It will give you each line were the code does not follow the linter convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from sync request to async requests. If there is an error in any of the requests it is treated in the same way than before.