Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix windows wpt #4050

Merged
merged 8 commits into from
Feb 9, 2025
Merged

test: fix windows wpt #4050

merged 8 commits into from
Feb 9, 2025

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Feb 9, 2025

This relates to...

Not sure what changed in the way node:path#join behaves but caused inconsistencies recently.
Mostly the path resolution was wrong, so just adjusted it.

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@metcoder95 metcoder95 marked this pull request as ready for review February 9, 2025 10:58
@metcoder95 metcoder95 requested a review from KhafraDev February 9, 2025 10:58
@metcoder95
Copy link
Member Author

Tests are quite unstable

Copy link
Contributor

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the rest looks like flaky tests?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c7f3d77 into main Feb 9, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants