fix: always parse headers #3408
Conversation
|
@metcoder95 @mcollina I have some http2 and mock test failures I haven't been able to figure out. Would appreciate some help. |
ronag
added
the
semver-major
ronag
force-pushed
the
headers-object
branch
2 times, most recently
from
8160369 to
2666cdc
Compare
Changes onHeaders and onComplete headers/trailers to always be a pre-parsed headers record.
Where how? I tried updating docs. Did I miss something? |
|
This dispatcher handlers will start receiving the |
|
Will check the H2 issues throughout the day |
|
I think I managed to fix the failures |
greetings some test errors appear I wonder if these could be flakky? |
|
I don't believe they are flaky as they are pretty consistent across jobs: https://github.com/nodejs/undici/actions/runs/9980661941/job/27582582584?pr=3408#step:8:2242 Seems to be related with |
| } else { | ||
| const headersValue = headers[i + 1] | ||
| if (typeof headersValue === 'string') { | ||
| obj[key] = headersValue | ||
| } else { | ||
| obj[key] = Array.isArray(headersValue) ? headersValue.map(x => x.toString('utf8')) : headersValue.toString('utf8') | ||
| obj[key] = Array.isArray(headersValue) ? headersValue.map(x => x.toString('latin1')) : headersValue.toString('latin1') |
There was a problem hiding this comment.
@metcoder95 @mcollina PTAL
There was a problem hiding this comment.
Adjusted the tests to align with the change
|
It seems CI is still not happy... |
Changes onHeaders and onComplete headers/trailers to always be a pre-parsed headers record.