fix: Runtime exception in Node SEA mode #106
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nodejs#105 by adding a check for `require.resolve` before trying to access `require.resolve.paths`.
timfish
approved these changes
Feb 3, 2025
jsumners-nr
approved these changes
Feb 3, 2025
|
We need to get #103 merged before this PR with the correct tokens in CI so that release automation works! |
trentm
approved these changes
Feb 4, 2025
dargmuesli
approved these changes
Feb 5, 2025
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105 by adding a check for
require.resolvebefore trying to accessrequire.resolve.paths.