Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Runtime exception in Node SEA mode #106

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

BYK
Copy link
Contributor

@BYK BYK commented Feb 3, 2025

Fixes #105 by adding a check for require.resolve before trying to access require.resolve.paths.

Fixes nodejs#105 by adding a check for `require.resolve` before trying to access `require.resolve.paths`.
@timfish
Copy link
Contributor

timfish commented Feb 3, 2025

We need to get #103 merged before this PR with the correct tokens in CI so that release automation works!

@timfish timfish merged commit d99df4b into nodejs:main Feb 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using with Node SEA
5 participants