Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scorecard badge #5661

Merged
merged 1 commit into from
Aug 27, 2023
Merged

add scorecard badge #5661

merged 1 commit into from
Aug 27, 2023

Conversation

UlisesGascon
Copy link
Member

Refs: #5659

@UlisesGascon UlisesGascon requested a review from a team as a code owner August 22, 2023 10:25
@vercel
Copy link

vercel bot commented Aug 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 10:27am

@UlisesGascon UlisesGascon mentioned this pull request Aug 22, 2023
Closed
6 tasks
@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
 92.21% (367/398) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 7.968s ⏱️

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

ovflowd
ovflowd approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

bmuenzenmeyer
bmuenzenmeyer approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really neat stuff - thanks for sharing. I am happy to see how this can push us to be better and actively monitor our posture over time

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Aug 27, 2023
Merged via the queue into nodejs:main with commit 6a1b637 Aug 27, 2023
@UlisesGascon UlisesGascon deleted the feat/add-scorecard-badge branch August 27, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@ovflowd ovflowd ovflowd approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UlisesGascon @bmuenzenmeyer @ovflowd @aymen94