Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix output of privateDecrypt with zero-length data #57575

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

crypto: fix output of privateDecrypt with zero-length data #57575

wants to merge 3 commits into from
+57 −1

Conversation

panva
Copy link
Member

@panva panva commented Mar 21, 2025 •
edited
Loading

closes #57553
closes #57572
closes #57558
refs #56653

@panva panva added confirmed-bug Issues with confirmed bugs. crypto Issues and PRs related to the crypto subsystem. webcrypto labels Mar 21, 2025
@panva panva requested a review from jasnell March 21, 2025 13:37
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 21, 2025
This was referenced Mar 21, 2025
Open
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (afe3909) to head (556183f).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57575      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.03%     
==========================================
  Files         630      630              
  Lines      185013   185054      +41     
  Branches    36249    36251       +2     
==========================================
- Hits       166969   166961       -8     
- Misses      10996    11030      +34     
- Partials     7048     7063      +15

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 21, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2025
tniessen
tniessen approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Optional nit: I'd prefer the test to have a less generic name, and ideally a reference to the GitHub issue describing the bug, but this is optional. For example, you could rename to test-crypto-oaep-zero-length and add a comment with a reference to the issue or rename to test-crypto-oaep-issue-57553 or so.

@panva
Copy link
Member Author

panva commented Mar 21, 2025

@tniessen thank you, I will take care of it if CI happens to fail again, otherwise in a followup PR.

@panva panva added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. confirmed-bug Issues with confirmed bugs. crypto Issues and PRs related to the crypto subsystem. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rsa-oaep decrypt the ciphertext (an empty string) got an unexpected string
6 participants
@panva @nodejs-github-bot @jasnell @lpinca @anonrig @tniessen