Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] deps: update undici to v5.29.0 #57557

Closed
wants to merge 1 commit into from
Closed

[v18.x] deps: update undici to v5.29.0 #57557

wants to merge 1 commit into from
+44 −32

Conversation

mcollina
Copy link
Member

This updates Undici to v5.29.0 in Node v18.

@mcollina
deps: update undici to v5.29.0
d3d41ef 
Signed-off-by: Matteo Collina <[email protected]>
@mcollina
Copy link
Member Author

cc @nodejs/releasers

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Mar 20, 2025
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65848/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65851/

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau
Copy link
Member

I'd like to fast track this so that I can include it in the Node.js 18 release that I'm preparing for next week.

I don't think the coverage failures are related to this change -- I've opened #57565 to see if backporting a change fixes that.

@richardlau richardlau mentioned this pull request Mar 20, 2025
Closed
Charlesnorris509
Charlesnorris509 reviewed Mar 25, 2025
View reviewed changes
Copy link

@Charlesnorris509 Charlesnorris509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like overall all your changes follow SWE best practices, however I would add comments on the code to make sure its readable

richardlau pushed a commit that referenced this pull request Mar 26, 2025
@mcollina @richardlau
deps: update undici to v5.29.0
69d661d 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #57557
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@richardlau
Copy link
Member

Landed in 69d661d.

@richardlau richardlau closed this Mar 26, 2025
@richardlau richardlau mentioned this pull request Mar 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charlesnorris509 Charlesnorris509 Charlesnorris509 left review comments

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcollina @nodejs-github-bot @richardlau @RafaelGSS @marco-ippolito @Charlesnorris509