test_runner: change ts default glob #57359

marco-ippolito · 2025-03-07T12:52:42Z

This PR changes the default glob for matching.ts files.
Basically will match only *test.{ts,mts,cts} inside the test folder.
This is the safest and middle ground to avoid breaking users.
I'd not consider a breaking change in v23 since typescript support is experimental.

Fixes: #56546

nodejs-github-bot · 2025-03-07T12:52:48Z

Review requested:

@nodejs/test_runner

codecov · 2025-03-07T14:01:26Z

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (4cc69f9) to head (464688e).
Report is 28 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/utils.js	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57359      +/-   ##
==========================================
+ Coverage   90.20%   90.21%   +0.01%     
==========================================
  Files         630      630              
  Lines      185307   185307              
  Branches    36271    36267       -4     
==========================================
+ Hits       167160   167181      +21     
- Misses      11085    11089       +4     
+ Partials     7062     7037      -25

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`89.02% <100.00%> (-0.49%)`	⬇️
lib/internal/test_runner/utils.js	`58.66% <66.66%> (ø)`

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/internal/test_runner/utils.js

mcollina

lgtm

I have a rough feeling this is semver-major.

marco-ippolito · 2025-03-07T15:17:37Z

Since ts is experimental its should be fine, also from my pov we are fixing a bug.
For example by matching all .ts, it was matching also .d.ts.
I know it might break some people but this is a much safer default

mcollina

lgtm

mcollina · 2025-03-07T15:23:04Z

@marco-ippolito ok

nodejs-github-bot · 2025-03-07T15:27:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65632/

JakobJingleheimer · 2025-03-07T15:30:32Z

For v24.0, can we remove the restriction requiring a test folder?

marco-ippolito · 2025-03-07T15:47:21Z

I think the issue is that people keep their test.ts in the src folder and transpile them, so they will be executed twice.
Once node v20 goes EOL we can be more lax and include other patterns

nodejs-github-bot · 2025-03-07T18:02:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65636/

ShogunPanda

LGTM!

nodejs-github-bot · 2025-03-08T06:52:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65645/

nodejs-github-bot · 2025-03-09T12:55:42Z

Landed in 9df0ff7

PR-URL: #57359 Fixes: #56546 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

@geeksilva97

Notable changes: crypto: * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 doc: * add @geeksilva97 to collaborators (Edy Silva) #57241 src: * (SEMVER-MINOR) set default config as node.config.json (Marco Ippolito) #57171 * (SEMVER-MINOR) create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING (Marco Ippolito) #57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 test_runner: * (SEMVER-MINOR) change ts default glob (Marco Ippolito) #57359 tls: * (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107 v8: * (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146 PR-URL: #57424

styfle · 2025-03-12T14:12:48Z

lib/internal/test_runner/utils.js

@@ -290,7 +290,7 @@ function parseCommandLine() {
    if (!coverageExcludeGlobs || coverageExcludeGlobs.length === 0) {
      // TODO(pmarchini): this default should follow something similar to c8 defaults


Are we still planning todo c8 defaults like the comment mentions?

@geeksilva97

Notable changes: crypto: * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 doc: * add @geeksilva97 to collaborators (Edy Silva) #57241 src: * (SEMVER-MINOR) set default config as node.config.json (Marco Ippolito) #57171 * (SEMVER-MINOR) create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING (Marco Ippolito) #57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 test_runner: * (SEMVER-MINOR) change ts default glob (Marco Ippolito) #57359 tls: * (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107 v8: * (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146 PR-URL: #57424

Notable changes: config: * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 crypto: * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 doc: * add geeksilva97 to collaborators (Edy Silva) #57241 src: * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 test_runner: * (SEMVER-MINOR) change ts default glob (Marco Ippolito) #57359 tls: * (SEMVER-MINOR) implement `tls.getCACertificates()` (Joyee Cheung) #57107 v8: * (SEMVER-MINOR) add `v8.getCppHeapStatistics()` method (Aditi) #57146 PR-URL: #57424

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 7, 2025

marco-ippolito added the strip-types Issues or PRs related to strip-types support label Mar 7, 2025

marco-ippolito mentioned this pull request Mar 7, 2025

Test runner matching every .ts and .js if glob is not provided #56546

Closed

cjihrig reviewed Mar 7, 2025

View reviewed changes

lib/internal/test_runner/utils.js Outdated Show resolved Hide resolved

marco-ippolito force-pushed the drop-some-ts-test-runner branch from fd014be to 844d7b0 Compare March 7, 2025 15:13

test_runner: change ts default glob

464688e

marco-ippolito force-pushed the drop-some-ts-test-runner branch from 844d7b0 to 464688e Compare March 7, 2025 15:14

mcollina approved these changes Mar 7, 2025

View reviewed changes

cjihrig approved these changes Mar 7, 2025

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2025

mcollina approved these changes Mar 7, 2025

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2025

pmarchini approved these changes Mar 7, 2025

View reviewed changes

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2025

ShogunPanda approved these changes Mar 8, 2025

View reviewed changes

pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2025

MoLow approved these changes Mar 9, 2025

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 9, 2025

nodejs-github-bot merged commit 9df0ff7 into nodejs:main Mar 9, 2025
62 checks passed

marco-ippolito added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. and removed notable-change PRs with changes that should be highlighted in changelogs. labels Mar 11, 2025

nodejs deleted a comment from github-actions bot Mar 11, 2025

github-actions bot mentioned this pull request Mar 12, 2025

2025-03-13, Version 23.10.0 (Current) #57424

Merged

styfle reviewed Mar 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test_runner: change ts default glob #57359

test_runner: change ts default glob #57359

marco-ippolito commented Mar 7, 2025 •

edited

Loading

nodejs-github-bot commented Mar 7, 2025

codecov bot commented Mar 7, 2025 •

edited

Loading

mcollina left a comment

marco-ippolito commented Mar 7, 2025 •

edited

Loading

mcollina left a comment

mcollina commented Mar 7, 2025

nodejs-github-bot commented Mar 7, 2025

JakobJingleheimer commented Mar 7, 2025

marco-ippolito commented Mar 7, 2025 •

edited

Loading

nodejs-github-bot commented Mar 7, 2025

ShogunPanda left a comment

nodejs-github-bot commented Mar 8, 2025

nodejs-github-bot commented Mar 9, 2025

styfle Mar 12, 2025

marco-ippolito Mar 12, 2025

		@@ -290,7 +290,7 @@ function parseCommandLine() {
		if (!coverageExcludeGlobs \|\| coverageExcludeGlobs.length === 0) {
		// TODO(pmarchini): this default should follow something similar to c8 defaults

test_runner: change ts default glob #57359

test_runner: change ts default glob #57359

Conversation

marco-ippolito commented Mar 7, 2025 • edited Loading

nodejs-github-bot commented Mar 7, 2025

codecov bot commented Mar 7, 2025 • edited Loading

Codecov Report

mcollina left a comment

Choose a reason for hiding this comment

marco-ippolito commented Mar 7, 2025 • edited Loading

mcollina left a comment

Choose a reason for hiding this comment

mcollina commented Mar 7, 2025

nodejs-github-bot commented Mar 7, 2025

JakobJingleheimer commented Mar 7, 2025

marco-ippolito commented Mar 7, 2025 • edited Loading

nodejs-github-bot commented Mar 7, 2025

ShogunPanda left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 8, 2025

nodejs-github-bot commented Mar 9, 2025

styfle Mar 12, 2025

Choose a reason for hiding this comment

marco-ippolito Mar 12, 2025

Choose a reason for hiding this comment

marco-ippolito commented Mar 7, 2025 •

edited

Loading

codecov bot commented Mar 7, 2025 •

edited

Loading

marco-ippolito commented Mar 7, 2025 •

edited

Loading

marco-ippolito commented Mar 7, 2025 •

edited

Loading