Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: use more defensive code when handling SWC errors #56646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 17, 2025

In case the thrown error is not of the shape we expect, we get a TypeError but an ERR_INTERNAL_ASSERTION

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (2e45656) to head (7c1116a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/modules/typescript.js 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56646      +/-   ##
==========================================
- Coverage   89.21%   89.20%   -0.02%     
==========================================
  Files         662      662              
  Lines      191883   191886       +3     
  Branches    36941    36932       -9     
==========================================
- Hits       171196   171176      -20     
- Misses      13536    13547      +11     
- Partials     7151     7163      +12     
Files with missing lines Coverage Δ
lib/internal/modules/typescript.js 97.05% <50.00%> (-0.55%) ⬇️

... and 36 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants