Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.x backport] doc: consolidate history table of CustomEvent #55805

Open
wants to merge 1 commit into
base: v22.x-staging
Choose a base branch
from

Conversation

geeksilva97
Copy link
Contributor

Backport of: #55758
Fixes: #55733
Refs: #55733

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 10, 2024
@geeksilva97 geeksilva97 marked this pull request as ready for review November 10, 2024 02:15
@aduh95
Copy link
Contributor

aduh95 commented Nov 10, 2024

The commit message should be the same as the one that landed on 23.x (355af0f), including the metadata (Reviewed-by, PR-URL, etc.). It should also have the same author and date.

PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@geeksilva97
Copy link
Contributor Author

The commit message should be the same as the one that landed on 23.x (355af0f), including the metadata (Reviewed-by, PR-URL, etc.). It should also have the same author and date.

Got it. It's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants