test: remove interval and give more time to unsync #55006
Conversation
|
Review requested:
|
nodejs-github-bot
added
needs-ci
pmarchini
force-pushed
the
issue/54807
branch
from
e6e0999
to
9daffe6
Compare
RedYetiDev
added
the
test_runner
| await new Promise((resolve) => setTimeout(() => { | ||
| unlinkSync(fileToDeletePathLocal); | ||
| resolve(); | ||
| }, common.platformTimeout(1000))); |
There was a problem hiding this comment.
Can/Should this be simplified with node:timers/promises?
There was a problem hiding this comment.
I didn't think about it, thanks for the suggestion, I'll take a look 😁
There was a problem hiding this comment.
Would using node:fs/promises be enough here? It seems weird to have to put a sync operation in an async one
There was a problem hiding this comment.
Hey @aduh95, yes, no problem at all.
The only important logic is the "sleep" after the delete to ensure that the watcher has received the event and completed the test run before proceeding.
Thanks for your feedback, I'll fixit ASAP 😁
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55006 +/- ##
==========================================
- Coverage 88.04% 88.03% -0.01%
==========================================
Files 652 652
Lines 183765 183761 -4
Branches 35863 35857 -6
==========================================
- Hits 161789 161769 -20
- Misses 15229 15233 +4
- Partials 6747 6759 +12 |
This PR should address #54807.
I'm leaving this in Draft while testing more extensively 🚀