Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake test-http-remove-header-stays-removed #55004

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 19, 2024

Instead of relying on a timer, verify that socket.end() is called when the 'finish' event is emitted on the ServerResponse object.

Instead of relying on a timer, verify that `socket.end()` is called when
the `'finish'` event is emitted on the `ServerResponse` object.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 19, 2024
@lpinca
Copy link
Member Author

lpinca commented Sep 19, 2024

Fixes https://ci.nodejs.org/job/node-test-commit-linux-containered/46445/nodes=ubuntu2204_sharedlibs_shared_x64/testReport/junit/(root)/parallel/test_http_remove_header_stays_removed/

---
duration_ms: 803.619
exitcode: 1
severity: fail
stack: |-
  ok
  node:assert:90
    throw new AssertionError(obj);
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

  false !== true

      at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-http-remove-header-stays-removed.js:61:18)
      at listOnTimeout (node:internal/timers:614:17)
      at process.processTimers (node:internal/timers:549:7) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: false,
    expected: true,
    operator: 'strictEqual'
  }

  Node.js v23.0.0-pre
...

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (c42d846) to head (673e7ce).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55004   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         652      652           
  Lines      183759   183759           
  Branches    35861    35856    -5     
=======================================
+ Hits       161770   161772    +2     
+ Misses      15239    15236    -3     
- Partials     6750     6751    +1     

see 34 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants