test: add asserts to validate test assumptions #54997
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#54968 Refs: nodejs#53382 Add additional asserts as suggestd by Richard in: nodejs#54968 Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Sep 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54997 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 652 652
Lines 183765 183764 -1
Branches 35858 35865 +7
=======================================
+ Hits 161771 161777 +6
+ Misses 15239 15237 -2
+ Partials 6755 6750 -5 |
Co-authored-by: Richard Lau <[email protected]>
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Sep 19, 2024
lpinca
added
the
commit-queue
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #54968
Refs: #53382
Add additional asserts as suggestd by Richard in:
#54968