module: expose getPackageScopeConfig & add findNearestPackageJSON
#54992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
RedYetiDev
added
wip
anonrig
reviewed
Sep 18, 2024
| @@ -64,6 +71,7 @@ function deserializePackageJSON(path, contents) { | |||
| ObjectDefineProperty(this, 'exports', { __proto__: null, value }); | |||
| return this.exports; | |||
| }, | |||
| ...(everything && contents[6]), | |||
There was a problem hiding this comment.
Can we be explicit? Depending on the package.json this can overwrite existing values in this object
| void BindingData::GetNearestParentPackageJSON( | ||
| const v8::FunctionCallbackInfo<v8::Value>& args | ||
| ) { | ||
| std::string path_value_str = FindNearestParentPackageJSON(args); |
There was a problem hiding this comment.
No need to append the type to the variable name
Suggested change
| std::string path_value_str = FindNearestParentPackageJSON(args); | |
| auto path = FindNearestParentPackageJSON(args); |
| args.GetReturnValue().Set(path_value_str); | ||
| } | ||
|
|
||
| void BindingData::GetNearestParentPackageJSON( |
There was a problem hiding this comment.
We need to also update typings folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft is not ready for review. Opening it in its current state for visibility.