Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test-http-max-sockets flaky designation #54976

Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 17, 2024

There is no recent trace of failure for this test.

Fixes: #47116

There is no recent trace of failure for this test.

Fixes: nodejs#47116
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (e21984b) to head (b569eff).
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54976      +/-   ##
==========================================
+ Coverage   88.04%   88.06%   +0.02%     
==========================================
  Files         651      652       +1     
  Lines      183409   183546     +137     
  Branches    35828    35860      +32     
==========================================
+ Hits       161487   161647     +160     
+ Misses      15174    15146      -28     
- Partials     6748     6753       +5     

see 56 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 18, 2024

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit 636b343 into nodejs:main Sep 20, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 636b343

@lpinca lpinca deleted the remove/flaky-test-http-max-sockets branch September 22, 2024 05:54
targos pushed a commit that referenced this pull request Oct 4, 2024
There is no recent trace of failure for this test.

Fixes: #47116
PR-URL: #54976
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
There is no recent trace of failure for this test.

Fixes: nodejs#47116
PR-URL: nodejs#54976
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-http-max-sockets fails in node-test-binary-windows-js-suites
4 participants