Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add unistd.h import if node posix credentials is defined #54528

Merged
merged 1 commit into from
Sep 20, 2024
Merged

src: add unistd.h import if node posix credentials is defined #54528

merged 1 commit into from
Sep 20, 2024

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented Aug 23, 2024

Fixes #54519

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 23, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (291d90a) to head (fc8de8f).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54528      +/-   ##
==========================================
- Coverage   88.04%   88.03%   -0.01%     
==========================================
  Files         652      652              
  Lines      183764   183764              
  Branches    35862    35862              
==========================================
- Hits       161787   161782       -5     
- Misses      15233    15236       +3     
- Partials     6744     6746       +2
Files with missing lines Coverage Δ
src/compile_cache.cc 80.00% <ø> (ø)

... and 37 files with indirect coverage changes

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61400/

@VoltrexKeyva
Copy link
Member

Typo in commit message, unitsd.h -> unistd.h.

@jasnell
Copy link
Member

jasnell commented Sep 8, 2024

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62168/

@JonasBa JonasBa changed the title src: add unitsd.h import if node posix credentials is defined src: add unisdt.h import if node posix credentials is defined Sep 19, 2024
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62581/

@JonasBa
Copy link
Contributor Author

JonasBa commented Sep 20, 2024

I've rebased the PR, should be good to merge now, thank you @jasnell and sorry for the delay, I was on vacation!

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@richardlau richardlau changed the title src: add unisdt.h import if node posix credentials is defined src: add unistd.h import if node posix credentials is defined Sep 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit fd8c762 into nodejs:main Sep 20, 2024
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fd8c762

targos pushed a commit that referenced this pull request Oct 4, 2024
@JonasBa @targos
src: add unistd.h import if node posix credentials is defined
0876f78 
usage comment

PR-URL: #54528
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@JonasBa @louwers
src: add unistd.h import if node posix credentials is defined
919af16 
usage comment

PR-URL: nodejs#54528
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getuid() needs unistd.h
7 participants
@JonasBa @nodejs-github-bot @VoltrexKeyva @jasnell @addaleax @anonrig @richardlau