Merge branch 'main' into actions/tools-update-cjs-module-lexer

.devcontainer/devcontainer.json

@@ -0,0 +1,19 @@
+{
+  "name": "Node.js Core Developer Environment",
+  "extensions": [
+    "github.vscode-pull-request-github",
+    "ms-vsliveshare.vsliveshare",
+    "vscode-icons-team.vscode-icons",
+    "visualstudioexptteam.vscodeintellicode"
+  ],
+  "image": "nodejs/devcontainer:nightly",
+  "initializeCommand": "docker system prune -f -a",
+  "settings": {
+    "terminal.integrated.profiles.linux": {
+      "zsh (login)": {
+        "path": "zsh",
+        "args": ["-l"]
+      }
+    }
+  }
+}

.eslintrc.js

@@ -19,6 +19,7 @@ const hacks = [
   'eslint-plugin-markdown',
   '@babel/eslint-parser',
   '@babel/plugin-syntax-import-attributes',
+  '@stylistic/eslint-plugin-js',
 ];
 Module._findPath = (request, paths, isMain) => {
   const r = ModuleFindPath(request, paths, isMain);
@@ -39,7 +40,7 @@ module.exports = {
     es2022: true,
   },
   extends: ['eslint:recommended', 'plugin:jsdoc/recommended'],
-  plugins: ['jsdoc', 'markdown', 'node-core'],
+  plugins: ['jsdoc', 'markdown', 'node-core', '@stylistic/js'],
   parser: '@babel/eslint-parser',
   parserOptions: {
     babelOptions: {
@@ -57,6 +58,8 @@ module.exports = {
         'test/es-module/test-esm-example-loader.js',
         'test/es-module/test-esm-type-flag.js',
         'test/es-module/test-esm-type-flag-alias.js',
+        'test/es-module/test-require-module-detect-entry-point.js',
+        'test/es-module/test-require-module-detect-entry-point-aou.js',
       ],
       parserOptions: { sourceType: 'module' },
     },
@@ -133,11 +136,7 @@ module.exports = {
     // https://eslint.org/docs/rules/
     'accessor-pairs': 'error',
     'array-callback-return': 'error',
-    'arrow-parens': 'error',
-    'arrow-spacing': 'error',
     'block-scoped-var': 'error',
-    'block-spacing': 'error',
-    'brace-style': ['error', '1tbs', { allowSingleLine: true }],
     'capitalized-comments': ['error', 'always', {
       line: {
         // Ignore all lines that have less characters than 20 and all lines that
@@ -150,49 +149,17 @@ module.exports = {
         ignorePattern: '.*',
       },
     }],
-    'comma-dangle': ['error', 'always-multiline'],
-    'comma-spacing': 'error',
-    'comma-style': 'error',
-    'computed-property-spacing': 'error',
     'default-case-last': 'error',
-    'dot-location': ['error', 'property'],
     'dot-notation': 'error',
-    'eol-last': 'error',
     'eqeqeq': ['error', 'smart'],
-    'func-call-spacing': 'error',
     'func-name-matching': 'error',
     'func-style': ['error', 'declaration', { allowArrowFunctions: true }],
-    'indent': ['error', 2, {
-      ArrayExpression: 'first',
-      CallExpression: { arguments: 'first' },
-      FunctionDeclaration: { parameters: 'first' },
-      FunctionExpression: { parameters: 'first' },
-      MemberExpression: 'off',
-      ObjectExpression: 'first',
-      SwitchCase: 1,
-    }],
-    'key-spacing': 'error',
-    'keyword-spacing': 'error',
-    'linebreak-style': 'error',
-    'max-len': ['error', {
-      code: 120,
-      ignorePattern: '^// Flags:',
-      ignoreRegExpLiterals: true,
-      ignoreTemplateLiterals: true,
-      ignoreUrls: true,
-      tabWidth: 2,
-    }],
-    'new-parens': 'error',
-    'no-confusing-arrow': 'error',
     'no-constant-condition': ['error', { checkLoops: false }],
     'no-constructor-return': 'error',
     'no-duplicate-imports': 'error',
     'no-else-return': 'error',
-    'no-extra-parens': ['error', 'functions'],
     'no-lonely-if': 'error',
     'no-mixed-requires': 'error',
-    'no-multi-spaces': ['error', { ignoreEOLComments: true }],
-    'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }],
     'no-new-require': 'error',
     'no-path-concat': 'error',
     'no-proto': 'error',
@@ -257,10 +224,8 @@ module.exports = {
       },
     ],
     'no-self-compare': 'error',
-    'no-tabs': 'error',
     'no-template-curly-in-string': 'error',
     'no-throw-literal': 'error',
-    'no-trailing-spaces': 'error',
     'no-undef': ['error', { typeof: true }],
     'no-undef-init': 'error',
     'no-unused-expressions': ['error', { allowShortCircuit: true }],
@@ -276,39 +241,11 @@ module.exports = {
     'no-useless-return': 'error',
     'no-var': 'error',
     'no-void': 'error',
-    'no-whitespace-before-property': 'error',
-    'object-curly-newline': 'error',
-    'object-curly-spacing': ['error', 'always'],
     'one-var': ['error', { initialized: 'never' }],
-    'one-var-declaration-per-line': 'error',
-    'operator-linebreak': ['error', 'after'],
-    'padding-line-between-statements': [
-      'error',
-      { blankLine: 'always', prev: 'function', next: 'function' },
-    ],
     'prefer-const': ['error', { ignoreReadBeforeAssign: true }],
     'prefer-object-has-own': 'error',
-    'quotes': ['error', 'single', { avoidEscape: true }],
-    'quote-props': ['error', 'consistent'],
-    'rest-spread-spacing': 'error',
-    'semi': 'error',
-    'semi-spacing': 'error',
-    'space-before-blocks': ['error', 'always'],
-    'space-before-function-paren': ['error', {
-      anonymous: 'never',
-      named: 'never',
-      asyncArrow: 'always',
-    }],
-    'space-in-parens': 'error',
-    'space-infix-ops': 'error',
-    'space-unary-ops': 'error',
-    'spaced-comment': ['error', 'always', {
-      'block': { 'balanced': true },
-      'exceptions': ['-'],
-    }],
     'strict': ['error', 'global'],
     'symbol-description': 'error',
-    'template-curly-spacing': 'error',
     'unicode-bom': 'error',
     'valid-typeof': ['error', { requireStringLiterals: true }],
 
@@ -327,6 +264,74 @@ module.exports = {
     'jsdoc/check-tag-names': 'off',
     'jsdoc/require-returns': 'off',
 
+    // Stylistic rules
+    '@stylistic/js/arrow-parens': 'error',
+    '@stylistic/js/arrow-spacing': 'error',
+    '@stylistic/js/block-spacing': 'error',
+    '@stylistic/js/brace-style': ['error', '1tbs', { allowSingleLine: true }],
+    '@stylistic/js/comma-dangle': ['error', 'always-multiline'],
+    '@stylistic/js/comma-spacing': 'error',
+    '@stylistic/js/comma-style': 'error',
+    '@stylistic/js/computed-property-spacing': 'error',
+    '@stylistic/js/dot-location': ['error', 'property'],
+    '@stylistic/js/eol-last': 'error',
+    '@stylistic/js/func-call-spacing': 'error',
+    '@stylistic/js/indent': ['error', 2, {
+      ArrayExpression: 'first',
+      CallExpression: { arguments: 'first' },
+      FunctionDeclaration: { parameters: 'first' },
+      FunctionExpression: { parameters: 'first' },
+      MemberExpression: 'off',
+      ObjectExpression: 'first',
+      SwitchCase: 1,
+    }],
+    '@stylistic/js/key-spacing': 'error',
+    '@stylistic/js/keyword-spacing': 'error',
+    '@stylistic/js/linebreak-style': 'error',
+    '@stylistic/js/max-len': ['error', {
+      code: 120,
+      ignorePattern: '^// Flags:',
+      ignoreRegExpLiterals: true,
+      ignoreTemplateLiterals: true,
+      ignoreUrls: true,
+      tabWidth: 2,
+    }],
+    '@stylistic/js/new-parens': 'error',
+    '@stylistic/js/no-confusing-arrow': 'error',
+    '@stylistic/js/no-extra-parens': ['error', 'functions'],
+    '@stylistic/js/no-multi-spaces': ['error', { ignoreEOLComments: true }],
+    '@stylistic/js/no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }],
+    '@stylistic/js/no-tabs': 'error',
+    '@stylistic/js/no-trailing-spaces': 'error',
+    '@stylistic/js/no-whitespace-before-property': 'error',
+    '@stylistic/js/object-curly-newline': 'error',
+    '@stylistic/js/object-curly-spacing': ['error', 'always'],
+    '@stylistic/js/one-var-declaration-per-line': 'error',
+    '@stylistic/js/operator-linebreak': ['error', 'after'],
+    '@stylistic/js/padding-line-between-statements': [
+      'error',
+      { blankLine: 'always', prev: 'function', next: 'function' },
+    ],
+    '@stylistic/js/quotes': ['error', 'single', { avoidEscape: true }],
+    '@stylistic/js/quote-props': ['error', 'consistent'],
+    '@stylistic/js/rest-spread-spacing': 'error',
+    '@stylistic/js/semi': 'error',
+    '@stylistic/js/semi-spacing': 'error',
+    '@stylistic/js/space-before-blocks': ['error', 'always'],
+    '@stylistic/js/space-before-function-paren': ['error', {
+      anonymous: 'never',
+      named: 'never',
+      asyncArrow: 'always',
+    }],
+    '@stylistic/js/space-in-parens': 'error',
+    '@stylistic/js/space-infix-ops': 'error',
+    '@stylistic/js/space-unary-ops': 'error',
+    '@stylistic/js/spaced-comment': ['error', 'always', {
+      'block': { 'balanced': true },
+      'exceptions': ['-'],
+    }],
+    '@stylistic/js/template-curly-spacing': 'error',
+
     // Custom rules from eslint-plugin-node-core
     'node-core/no-unescaped-regexp-dot': 'error',
     'node-core/no-duplicate-requires': 'error',

.gitattributes

@@ -4,3 +4,4 @@ deps/npm/bin/npm text eol=lf
 deps/npm/bin/npx text eol=lf
 deps/corepack/shims/corepack text eol=lf
 tools/msvs/find_python.cmd text eol=crlf
+doc/**/*.md text eol=lf

.github/CODEOWNERS

@@ -17,6 +17,7 @@
 /CONTRIBUTING.md @nodejs/tsc
 /doc/contributing/*.md @nodejs/tsc
 /GOVERNANCE.md @nodejs/tsc
+/SECURITY.md @nodejs/tsc
 /LICENSE @nodejs/tsc
 /onboarding.md @nodejs/tsc
 
@@ -59,6 +60,8 @@
 
 # tls/crypto
 
+/doc/api/crypto.md @nodejs/crypto
+/doc/api/webcrypto.md @nodejs/crypto
 /lib/crypto.js @nodejs/crypto
 /lib/internal/crypto/* @nodejs/crypto
 /lib/internal/tls/* @nodejs/crypto @nodejs/net
@@ -93,7 +96,6 @@
 /doc/api/packages.md @nodejs/loaders
 /lib/internal/bootstrap/realm.js @nodejs/loaders
 /lib/internal/modules/* @nodejs/loaders
-/lib/internal/process/esm_loader.js @nodejs/loaders
 /lib/internal/process/execution.js @nodejs/loaders
 /lib/module.js @nodejs/loaders
 /src/module_wrap* @nodejs/loaders @nodejs/vm
@@ -122,7 +124,7 @@
 
 # Startup
 
-/benchmark/misc/startup.js @nodejs/startup
+/benchmark/misc/startup-* @nodejs/startup
 /lib/internal/bootstrap/* @nodejs/startup
 /src/node_builtins* @nodejs/startup
 /src/node_realm* @nodejs/startup @nodejs/realm
@@ -171,8 +173,11 @@
 /.github/workflows/tools.yml @nodejs/security-wg
 /.github/workflows/update-openssl.yml @nodejs/security-wg
 /.github/workflows/update-v8.yml @nodejs/security-wg @nodejs/v8-update
+/deps @nodejs/security-wg
 /tools/dep_updaters/* @nodejs/security-wg
 
 # Web Standards
 /lib/internal/bootstrap/web/* @nodejs/web-standards
 /lib/internal/navigator.js @nodejs/web-standards
+/test/fixtures/wpt/ @nodejs/web-standards
+/test/wpt/ @nodejs/web-standards

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -27,7 +27,11 @@ body:
   - type: textarea
     attributes:
       label: What steps will reproduce the bug?
-      description: Enter details about your bug, preferably a simple code snippet that can be run using `node` directly without installing third-party dependencies.
+      description: >
+        Enter details about your bug, preferably a simple code snippet that can
+        be run using `node` directly without installing third-party dependencies
+        or downloading code from the internet (i.e. no ZIP archive, no GitHub
+        repository, etc.).
   - type: textarea
     attributes:
       label: How often does it reproduce? Is there a required condition?

.github/label-pr-config.yml

@@ -86,7 +86,7 @@ subSystemLabels:
   # Oddities first
   /^lib\/(?:punycode|\w+\/freelist|sys\.js)/: ''
   /^lib\/constants\.js$/: lib / src
-  /^lib\/internal/debugger$/: debugger
+  /^lib\/internal\/debugger$/: debugger
   /^lib\/internal\/linkedlist\.js$/: timers
   /^lib\/internal\/bootstrap/: lib / src
   /^lib\/internal\/v8_prof_/: tools

.github/workflows/auto-start-ci.yml

@@ -10,9 +10,8 @@ on:
 
 concurrency: ${{ github.workflow }}
 
-# todo (node-fetch not working on 18, waiting for node-core-utils to fix)
 env:
-  NODE_VERSION: 16
+  NODE_VERSION: lts/*
 
 permissions:
   contents: read
@@ -46,12 +45,12 @@ jobs:
     if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608  # v4.1.0
+      - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b  # v4.1.4
         with:
           persist-credentials: false
 
       - name: Install Node.js
-        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d  # v3.8.1
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8  # v4.0.2
         with:
           node-version: ${{ env.NODE_VERSION }}