Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for apply https://github.com/njh/EtherCard/issues/384 possible fix #385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrv96
Copy link

@mrv96 mrv96 commented Feb 9, 2020

No description provided.

@nuno-silva
Copy link
Contributor

Looks good, but I would also update the JeeUdp example sketch here

ether.sendUdp ((char*) collBuf, collPos, 23456, destIp, config.port);
to get rid of the invalid conversion warning: https://travis-ci.com/github/njh/EtherCard/jobs/367604836#L665-L672

udpClientSendOnly.ino is also affected, as it uses char*:

char textToSend[] = "test 123";
void loop () {
if (millis() > timer) {
timer = millis() + 5000;
//static void sendUdp (char *data,uint8_t len,uint16_t sport, uint8_t *dip, uint16_t dport);
ether.sendUdp(textToSend, sizeof(textToSend), srcPort, ether.hisip, dstPort );

@mrv96
Copy link
Author

mrv96 commented May 3, 2023

Squashed commits and updated examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants