Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: darwin cleanup #6531

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Feb 26, 2025

  • thunderbird: deprecate darwinSetupWarning option
  • tests: switch to wrapped mozilla packages for tests
  • thunderbird: remove package example that referred to old alias

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@github-actions github-actions bot added the mail label Feb 26, 2025
@booxter
Copy link
Contributor Author

booxter commented Feb 26, 2025

Context: NixOS/nixpkgs#377863

booxter added 3 commits March 9, 2025 18:51
nixpkgs support thunderbird for darwin now.

Signed-off-by: Ihar Hrachyshka <[email protected]>
Darwin now supports wrapping thunderbird and firefox.

Signed-off-by: Ihar Hrachyshka <[email protected]>
This package no longer exists in nixpkgs; instead of bumping it, just
leave it unset.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter booxter marked this pull request as ready for review March 9, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant