do not test JS target on Nim 1.6 #123

nitely · Aug 13, 2023 · 9a2a91b · 9a2a91b
1 parent ba60d6f
commit 9a2a91b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         # xxx trim to on use latest in each branch eg 1.0.10, 1.2.8 etc
-        nim: [1.6.12]
+        nim: [1.0.0, 1.0.2, 1.0.4, 1.0.10, 1.2.0, 1.2.2, 1.2.4, 1.2.6, 1.2.12, 1.4.0, 1.4.2, 1.4.8, 1.6.14]
     steps:
     - uses: actions/checkout@v2
     - name: Run Tests

diff --git a/regex.nimble b/regex.nimble
@@ -24,7 +24,8 @@ task test2, "Test":
   # the docker image for CI has it since Nim 1.0.4,
   # so I'll only test it there
   when (NimMajor, NimMinor, NimPatch) >= (1, 0, 4) and
-      (NimMajor, NimMinor) != (1, 4):  # issue #88
+      (NimMajor, NimMinor) != (1, 4) and  # issue #88
+      (NimMajor, NimMinor) != (1, 6):  # issue #123
     exec "nim js -r src/regex.nim"
     exec "nim js -r tests/tests2.nim"
     exec "nim js -r -d:forceRegexAtRuntime tests/tests2.nim"