check-compliance-policy and check-imagie-FIPS added #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sratslla <[email protected]>
anusha94
reviewed
Feb 25, 2025
| template: | ||
| spec: | ||
| containers: | ||
| - name: discovery |
There was a problem hiding this comment.
Is the container name guaranteed to be discovery?
| kinds: | ||
| - Deployment | ||
| namespaces: | ||
| - istio-system |
There was a problem hiding this comment.
You should also add the match for istiod Deployment
There was a problem hiding this comment.
Also maybe a good idea to write the check for Pod instead
| - resources: | ||
| kinds: | ||
| - Pod | ||
| - Deployment |
There was a problem hiding this comment.
We should probably write the check only for Pod. Other controllers will be handled by auto-gen rules.
|
I will fix these and add the rest of the policies I have been working on in this PR by EOD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check-compliance-policy and check-imagie-FIPS-compliant added