Skip to content

MNT: Update netcdf to latest scipy #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

effigies
Copy link
Member

Seems numpy's release has forced our hand. No longer clear that tests will ensure we're getting mmaps. I'll open an issue with scipy.

Fixes #1108.

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1110 (9200261) into master (9fbddef) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
- Coverage   92.29%   92.25%   -0.05%     
==========================================
  Files         100      100              
  Lines       12247    12247              
  Branches     2393     2393              
==========================================
- Hits        11303    11298       -5     
- Misses        621      624       +3     
- Partials      323      325       +2     
Impacted Files Coverage Δ
nibabel/nifti1.py 92.13% <0.00%> (-0.46%) ⬇️
nibabel/volumeutils.py 93.73% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbddef...9200261. Read the comment docs.

@effigies effigies merged commit 1a34056 into nipy:master May 23, 2022
@effigies effigies deleted the mnt/fixup branch May 23, 2022 14:20
@effigies
Copy link
Member Author

Issue opened FWIW: scipy/scipy#16285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-release job is failing against master
1 participant