Feature/improved warnings for incomplete gbasf2 download #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically I removed the `if verbose` and just always print missing files if there are some missing. I realized that I don't really need the verbose parameter and with the printing of difference implemented by Arthur, it's also not necessary to print the list of all files. And anyway, if I can shorten code without any loss, it's better to do so. I don't think using many keyword parameters in private code is a good design pattern anyway, it's not a flag meant for users.
meliache
added
enhancement
meliache
deleted the
feature/improved-print-for-incomplete-gbasf2-download
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I removed the
if verboseand just always print missing/superfluous files if there are some.I realized that I don't really need the verbose parameter and with the printing of difference implemented by @ArturAkh , it's also not necessary to print the list of all files. And anyway, if I can shorten code without any loss, it's better to do so.
Also I replaced the prints by warnings, though I would like to have this replaced by proper logging in #100 .
Resolves #101