Eslint issue 44 fix #55
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding onto PR made by @subhajit20 PR #47, I went ahead and fixed the warnings with the "unexpected any." I also fixed the issue with the unexpected non-null assertion. Now when we run lint in the terminal using "npm run lint", there shouldn't be any more warnings.
This may not be correct however since I am using : @typescript-eslint/no-explicit-any : "off", which, by continuing to use any in the codebase, we're telling TypeScript to skip type checking for that variable or expression. This means that TypeScript won't catch potential type-related errors at compile-time, which can be a problem.
Would love to discuss better potential alternatives possibly, I was thinking of using "unknown" instead of "any" but I think it would change the way the components function.