Add a basic benchmark tool to xtask #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-bench-basic
branch
from
e7be444 to
2ccef62
Compare
tedbrandston
approved these changes
Mar 24, 2025
xtask/src/bench/walk.rs
Outdated
| ) -> Result<(), Ext4Error> { | ||
| let entry_iter = match fs.read_dir(path) { | ||
| Ok(entry_iter) => entry_iter, | ||
| Err(Ext4Error::Encrypted) => return Ok(()), |
There was a problem hiding this comment.
nit: feels like there should be some kinda warning here, but I'm not sure it's worth adding.
nicholasbishop
force-pushed
the
bishop-bench-basic
branch
2 times, most recently
from
92de9ac to
51d535e
Compare
For example, after running `cargo xtask download-big-filesystems`: ``` $ cargo xtask bench test_data/chromiumos_root.bin iter 1: filesystem hash: de095c100670bb05b5cd0d48449743c42a374e1284c3ea4928a4000d79e6a1ba 1.52s iter 2: filesystem hash: de095c100670bb05b5cd0d48449743c42a374e1284c3ea4928a4000d79e6a1ba 1.37s iter 3: filesystem hash: de095c100670bb05b5cd0d48449743c42a374e1284c3ea4928a4000d79e6a1ba 1.38s iter 4: filesystem hash: de095c100670bb05b5cd0d48449743c42a374e1284c3ea4928a4000d79e6a1ba 1.36s iter 5: filesystem hash: de095c100670bb05b5cd0d48449743c42a374e1284c3ea4928a4000d79e6a1ba 1.36s range: 1.36s - 1.52s median: 1.37s ```
nicholasbishop
force-pushed
the
bishop-bench-basic
branch
from
51d535e to
eb8bb48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, after running
cargo xtask download-big-filesystems: