-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ni-python-styleguide to version 0.4.1 #253
Conversation
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
@mshafer-NI I tried to fix the |
@bkeryan |
I upgraded to 0.4.1 before I tried to do this. I didn't know about |
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
|
checks-nimg was failing for two reasons:
|
- Copy `test_assets_directory` fixture from nidaqmx-python. - Replace `tmpdir` fixture with `tmp_path_factory`, which uses pathlib Signed-off-by: Brad Keryan <[email protected]>
What does this Pull Request accomplish?
Update
ni-python-styleguide
to version 0.4.1.Fix syntax of
noqa
comments. To ignore a specific error, you must put a colon afternoqa
, or else it ignores all errors.Fix import order in
__init__.py
.Remove docstrings from test case functions.
Why should this Pull Request be merged?
Fixes #250
Removes boilerplate docstrings from tests.
What testing has been done?
Ran
ni-python-styleguide lint
andpytest
.