This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Howto write a HashTranslateLoader #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In issue ngx-translate#25 @mlegenhausen pointed out a solution that shows a very common use-case for a custom TranslateLoader implementation. Maybe we can extend the readme to show this (and maybe other use-cases in the future)? Kind regards :)
tiaguinho
suggested changes
Mar 15, 2018
README.md
Outdated
| @@ -69,3 +69,47 @@ export function HttpLoaderFactory(http: HttpClient) { | |||
| ``` | |||
|
|
|||
| For now this loader only support the json format. | |||
|
|
|||
| ## Custom TranslateLoader strategies | |||
| ### HashTranslateLoader - Hashing translation files with angular-cli, webpack and SystemJS | |||
There was a problem hiding this comment.
I think you can remove the line 74 and change the title to Angular CLI/Webpack TranslateLoader Example
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| When your project cannot find `System` then adding this to your `typings.d.ts` file helps: |
There was a problem hiding this comment.
Cause System will not be available you need to add it to your custom typings.d.ts
README.md
Outdated
| import { TranslateLoader } from '@ngx-translate/core'; | ||
| import { Observable } from 'rxjs/Observable'; | ||
|
|
||
| export class HashTranslateLoader implements TranslateLoader { |
There was a problem hiding this comment.
It's more accurate changing the class name to WebpackTranslateLoader.
README.md
Outdated
| export class AppModule { } | ||
| ``` | ||
|
|
||
| One disadvantage of this solution is that you have to rebuild your application when there are only changes inside your language files. |
There was a problem hiding this comment.
I think will be better changed to:
The disadvantage of this solution is that you have to rebuild the application everytime your translate files has changes.
README.md
Outdated
|
|
||
| ## Custom TranslateLoader strategies | ||
| ### HashTranslateLoader - Hashing translation files with angular-cli, webpack and SystemJS | ||
| Allow caching of translation files by the browser could help to speed up the initial load of your app but with the default setup your translation files could miss the latest changes because the cache doesn't have the latest version of your translation file yet. |
README.md
Outdated
| ### HashTranslateLoader - Hashing translation files with angular-cli, webpack and SystemJS | ||
| Allow caching of translation files by the browser could help to speed up the initial load of your app but with the default setup your translation files could miss the latest changes because the cache doesn't have the latest version of your translation file yet. | ||
|
|
||
| When using the angular-cli (uses webpack under the hood) you can write your own `TranslateLoader` that always loads the latest translation file available during your application build. |
|
@tiaguinho thank you for your review. I've updated the file to your suggestions. |
tiaguinho
approved these changes
Mar 16, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #25 @mlegenhausen pointed out a solution that shows a very common use-case for a custom TranslateLoader implementation.
Maybe we can extend the readme to show this (and maybe other use-cases in the future)?
Kind regards :)
PS: my english is not the best, so feel free to improve it in any way