Skip to content

Refactor/nx #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 35 commits into from
Closed

Refactor/nx #61

wants to merge 35 commits into from

Conversation

ngfelixl
Copy link
Owner

@ngfelixl ngfelixl commented Dec 13, 2021

It is a completely different version, architecture, setup, dependencies.

You can read more about it here.

Checklist

  • Use an NX workspace
  • Migrate to @nrwl/workspace, @angular/core version 13
  • Setup an Angular application
  • Setup a NestJS application
  • Setup a dev-server
  • Use Websockets to establish a realtime connection
  • Use RxJS to stream app data to the frontend (Plot function accepts Plot[] | Observable<Plot[]>)
  • Server closes subscriptions if all connected windows are closed
  • Update documentation
  • Generate type definitions .d.ts automatically
  • Bundle all dependencies, inclusive NestJS
  • Add missing tests
  • Adjust CI
  • Create a release candidate

Here you can see a potential result. I would be happy to get feedback on this.

nodeplotlib

Also solves:

@ngfelixl
Copy link
Owner Author

It might not be the best solution to bundle the @nestjs dependencies. They should not rely on native C++ bindings, but it is not guaranteed. Therefore no external library should be bundled.

@ngfelixl ngfelixl closed this Dec 20, 2021
@ngfelixl ngfelixl deleted the refactor/use-nx branch December 20, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant