call readpartial and peeraddr on @socket if available to support puma's ... #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s ssl sockets
|
Awesome, much shorter. Could you add a test that covers the scenario where we have a different kind of socket? |
|
I found some more issues with puma's ssl socket, will fix them as well and add the test afterwards |
|
thanks! On Wed, Nov 12, 2014 at 9:41 AM, alexandermayr [email protected]
|
| end | ||
|
|
||
| def closed? | ||
| @socket.closed? | ||
| return @socket.closed? if @socket.respond_to?(:closed?) |
There was a problem hiding this comment.
This will not get call as it will fail when calling the method closed? and raise error at the first place.
added 2 commits
November 13, 2014 10:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same solution as #35 but with setting addrinfo through @socket.peeraddr