primaryAttributeKey check for string #662
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tag[primaryAttributeKey] is not string, it should return false. Since, In many cases we have tag[primaryAttributeKey] as object.
We get this error if the attr is an object
TypeError: tag[primaryAttributeKey].toLowerCase is not a function at /node_modules/react-helmet/lib/HelmetUtils.js:124:100 at Array.filter (<anonymous>) at /node_modules/react-helmet/lib/HelmetUtils.js:100:22 at Array.reduce (<anonymous>) at getTagsFromPropsList (/node_modules/react-helmet/lib/HelmetUtils.js:97:18) at reducePropsToState (/node_modules/react-helmet/lib/HelmetUtils.js:181:19)