Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace moment objects comparison #14441

Merged
merged 3 commits into from
Feb 21, 2025
Merged

fix: replace moment objects comparison #14441

merged 3 commits into from
Feb 21, 2025
+76 −74

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy requested a review from ShGKme February 17, 2025 11:39
@Antreesy Antreesy self-assigned this Feb 17, 2025
@Antreesy Antreesy requested a review from DorraJaouad February 19, 2025 09:38
@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Feb 20, 2025
DorraJaouad
DorraJaouad approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy
fix: replace moment objects comparison
c56c331 
- minor refactoring

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: replace moment.diff()
5d98af7 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: replace moment.add() and moment.startOf()
b864514 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/moment-replace-diff branch from 76757dd to b864514 Compare February 21, 2025 15:41
@Antreesy Antreesy merged commit 6a053c2 into main Feb 21, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/moment-replace-diff branch February 21, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review backport-request feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad