Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessagesList): rename method to pollNewMessages #14393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Non-breaking pre-requisite to feat(MessagesList) - history mode for old messages #10084
    • I'm giving up and will implement it by parts 👀
  • rename getNewMessages to pollNewMessages (to avoid confusion - get*Messages should not poll)
  • drop lookForNewMessages method as redundant
    • _isBeingDestroyed, _isDestroyed are internal Vue flags, different in Vue3, and not needed here
  • refactor fetchMessages to support both direction of lookIntoFuture (to make fetching the chunk of new messages possible)
  • refactor tests

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

- drop lookForNewMessages method as redundant

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Feb 14, 2025
@Antreesy Antreesy requested a review from ShGKme February 14, 2025 13:34
@Antreesy Antreesy self-assigned this Feb 14, 2025
@DorraJaouad DorraJaouad self-requested a review February 19, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant