-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MessagesList): fix resizeObserver and scrolledToBottom state update #14327
base: main
Are you sure you want to change the base?
Conversation
Could you explain the change? |
4729338
to
b6dcc12
Compare
@@ -932,24 +934,25 @@ export default { | |||
return | |||
} | |||
|
|||
this.setChatScrolledToBottom(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After swtiching to conversation, handleScroll is triggered. Regardless of container height, it sets value to false (whereas it shouldn't for non-scrollable chats)
For scrollable chats it also shouldn't set to false, when receiiving message (handleScroll is triggered with 'down' direction)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sthg is wrong, chat is sticky when document is not focused and it scrolls to bottom
- covered by hard update of list in messagesList watcher Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
… scroll up Signed-off-by: Maksim Sukharev <[email protected]>
b6dcc12
to
b38f22a
Compare
☑️ Resolves
setChatScrolledToBottom(false)
should be only set on scroll up (if we're scrolling down. it should be already set)🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏡 After
2025-02-10_09h13_03.mp4
🔬 Test
:key
:🏁 Checklist