Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textParse): use mention id to parse message parameters #14271

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix(textParse): use mention id to parse message parameters #14271

merged 2 commits into from
Feb 21, 2025
+101 −12

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 31, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Jan 31, 2025
@Antreesy Antreesy self-assigned this Jan 31, 2025
@nickvergessen nickvergessen force-pushed the feat/noid/expose-mention-id branch 3 times, most recently from 8fba13f to a2ed72a Compare February 7, 2025 15:32
Base automatically changed from feat/noid/expose-mention-id to main February 7, 2025 15:45
@nickvergessen nickvergessen force-pushed the feat/noid/expose-mention-id-frontend branch from 85283cd to 59ff5af Compare February 7, 2025 16:02
@Antreesy Antreesy force-pushed the feat/noid/expose-mention-id-frontend branch from 59ff5af to 3ec8793 Compare February 7, 2025 19:07
@Antreesy Antreesy marked this pull request as ready for review February 7, 2025 19:07
@Antreesy Antreesy force-pushed the feat/noid/expose-mention-id-frontend branch from 3ec8793 to c69e57a Compare February 7, 2025 19:15
@Antreesy
fix(textParse): refactor method and tests
ab350f3 
- wrap user mentions in double quotes

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(textParse): use mention id from message parameters if available
6cff311 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the feat/noid/expose-mention-id-frontend branch from c69e57a to 6cff311 Compare February 8, 2025 10:56
@nickvergessen nickvergessen mentioned this pull request Feb 11, 2025
Open
@Antreesy Antreesy requested a review from DorraJaouad February 19, 2025 11:54
DorraJaouad
DorraJaouad approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted

@Antreesy Antreesy merged commit 28a5364 into main Feb 21, 2025
53 checks passed
@Antreesy Antreesy deleted the feat/noid/expose-mention-id-frontend branch February 21, 2025 08:09
@Antreesy
Copy link
Contributor Author

/backport to stable31

@backportbot backportbot bot mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad