feat: Refactor form sync to run as a background job with retry #2408
+340
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIlkiv
force-pushed
the
form-sync-background-job
branch
2 times, most recently
from
e08797f
to
493c3fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2408 +/- ##
=======================================
Coverage ? 43.50%
Complexity ? 857
=======================================
Files ? 73
Lines ? 3232
Branches ? 0
=======================================
Hits ? 1406
Misses ? 1826
Partials ? 0 |
AIlkiv
force-pushed
the
form-sync-background-job
branch
from
493c3fe
to
d34796b
Compare
AIlkiv
changed the title
Signed-off-by: ailkiv <[email protected]>
|
Added a fix for the issue described in #2067 |
AIlkiv
force-pushed
the
form-sync-background-job
branch
from
d34796b
to
bc6bcab
Compare
This was
linked to
issues
Nov 14, 2024
Chartman123
added
bug
Chartman123
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Looks good to me :) I'd like to wait with the merging for @susnux's review
thanks for this PR, we can also do a backport to stable4, but you'll need to adjust the ApiController part there manually because of the duplicated routes.
|
/backport to stable4 |
|
The Codecov upload error isn't specific to Forms: codecov/codecov-action#1643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #2165 , #2067
I implemented a logic to synchronize the form with the file, allowing multiple attempts if the first one fails. The process runs in the background with delays, ensuring it does not impact the user experience.