-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User migration #1243
User migration #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
============================================
+ Coverage 32.60% 36.91% +4.30%
- Complexity 479 506 +27
============================================
Files 46 47 +1
Lines 1843 1956 +113
============================================
+ Hits 601 722 +121
+ Misses 1242 1234 -8 |
b93caaf
to
52ea027
Compare
Hmm, tests are of course only successful on NC24+. @nickvergessen can i somehow block these tests if NC<24? |
if (\OC_Util::getVersion()[0] < 24) {
$this->markTestSkipped('Not available in 22+23');
} |
a008a89
to
95a2019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice implementation. I did not test it yet.
f3c813c
to
aefcdf8
Compare
6bd708e
to
b6785cd
Compare
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Implementing the user migration for NC>24 :)
Implements #582