Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User migration #1243

Merged
merged 3 commits into from
Aug 21, 2022
Merged

User migration #1243

merged 3 commits into from
Aug 21, 2022

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Jul 8, 2022

Implementing the user migration for NC>24 :)

  • Submission loading shifted from Api-Controller to Service for reusability
  • Forms are exported including questions, and submissions.
  • Shares are not exported, as they will anyways change on a new instance.
  • UserIds on Submissions are mapped to federation UIDs to still have a connection on who submitted, but to avoid accidential wrong mapping on new instance.

Implements #582
grafik

@jotoeri jotoeri added enhancement New feature or request 3. to review Waiting for reviews labels Jul 8, 2022
@jotoeri jotoeri added this to the 3.0 milestone Jul 8, 2022
@jotoeri jotoeri linked an issue Jul 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1243 (1f0d906) into master (0d042b3) will increase coverage by 4.30%.
The diff coverage is 81.61%.

❗ Current head 1f0d906 differs from pull request most recent head 9713694. Consider uploading reports for the commit 9713694 to get more accurate results

@@             Coverage Diff              @@
##             master    #1243      +/-   ##
============================================
+ Coverage     32.60%   36.91%   +4.30%     
- Complexity      479      506      +27     
============================================
  Files            46       47       +1     
  Lines          1843     1956     +113     
============================================
+ Hits            601      722     +121     
+ Misses         1242     1234       -8     

@jotoeri jotoeri added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 8, 2022
@jotoeri jotoeri force-pushed the enh/export branch 2 times, most recently from b93caaf to 52ea027 Compare July 10, 2022 11:38
@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 10, 2022
@jotoeri
Copy link
Member Author

jotoeri commented Jul 10, 2022

Hmm, tests are of course only successful on NC24+. @nickvergessen can i somehow block these tests if NC<24?

@nickvergessen
Copy link
Member

if (\OC_Util::getVersion()[0] < 24) {
$this->markTestSkipped('Not available in 22+23');
}

Copy link

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation. I did not test it yet.

lib/AppInfo/Application.php Outdated Show resolved Hide resolved
lib/UserMigrator.php Outdated Show resolved Hide resolved
lib/UserMigrator.php Outdated Show resolved Hide resolved
lib/UserMigrator.php Outdated Show resolved Hide resolved
@jotoeri jotoeri added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 2, 2022
@jotoeri jotoeri force-pushed the enh/export branch 2 times, most recently from f3c813c to aefcdf8 Compare August 2, 2022 18:25
@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 3, 2022
@jotoeri jotoeri force-pushed the enh/export branch 2 times, most recently from 6bd708e to b6785cd Compare August 19, 2022 21:33
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
@jotoeri jotoeri added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 20, 2022
@jotoeri jotoeri merged commit 5dabc05 into master Aug 21, 2022
@jotoeri jotoeri deleted the enh/export branch August 21, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export and import forms
3 participants