fix: typo with no-fetch help message #649
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariyonaty
force-pushed
the
patch/typo-in-help
branch
from
d756fb3 to
27955ab
Compare
newren
requested changes
Mar 20, 2025
There was a problem hiding this comment.
Like git.git, for commit messages we want it of the form "area: summary" not "change-type: summary". Could you adjust to "filter-repo: fix typo with no-fetch help message"?
Also, for the Signed-off-by, we need it to be of the form Real Name <[email protected]>; not username <[email protected]>; @users.noreply.github.com addresses don't suffice. Can you fix this as well?
I'll be happy to apply with these two changes.
ariyonaty
force-pushed
the
patch/typo-in-help
branch
from
27955ab to
09fc795
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
newren
requested changes
Mar 21, 2025
Signed-off-by: Ari Yonaty <[email protected]>
ariyonaty
force-pushed
the
patch/typo-in-help
branch
from
09fc795 to
a4887fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.