Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kombu instrumentation import #1340

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Mar 28, 2025

The instrumentation for Kombu was missing an import of the global settings, causing a crash.

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 4 0 0 0.49s
✅ MARKDOWN markdownlint 7 0 0 0 1.11s
✅ MARKDOWN markdown-link-check 7 0 0 14.88s
✅ PYTHON ruff 893 0 0 0 0.59s
✅ PYTHON ruff-format 893 0 0 0 0.32s
✅ YAML prettier 10 0 0 0 1.23s
✅ YAML v8r 10 0 0 4.97s
✅ YAML yamllint 10 0 0 0.54s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (2c8f312) to head (b218414).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1340   +/-   ##
=======================================
  Coverage   81.48%   81.49%           
=======================================
  Files         204      204           
  Lines       22820    22821    +1     
  Branches     3617     3617           
=======================================
+ Hits        18595    18598    +3     
+ Misses       3013     3012    -1     
+ Partials     1212     1211    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lrafeei lrafeei marked this pull request as ready for review March 28, 2025 20:26
@lrafeei lrafeei requested a review from a team as a code owner March 28, 2025 20:26
@mergify mergify bot removed the tests-failing label Mar 28, 2025
@TimPansino TimPansino merged commit 0c59fe3 into main Mar 28, 2025
56 of 57 checks passed
@TimPansino TimPansino deleted the add-settings-import-kombu branch March 28, 2025 21:10
jairhenrique pushed a commit to jairhenrique/newrelic-python-agent that referenced this pull request Mar 28, 2025
@lrafeei lrafeei added this to the v10.8.1 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants