Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support str response type in Langchain #1333

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hmstepanek
Copy link
Contributor

Overview

Fix issue with Langchain where response is type string and only the first character is captured.

@hmstepanek hmstepanek changed the title Support str response type Support str response type in Langchain Mar 25, 2025
Copy link

github-actions bot commented Mar 25, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 4 0 0 0.43s
✅ MARKDOWN markdownlint 7 0 0 0 0.96s
✅ MARKDOWN markdown-link-check 7 0 0 16.8s
✅ PYTHON ruff 893 0 0 0 0.5s
✅ PYTHON ruff-format 893 0 0 0 0.28s
✅ YAML prettier 10 0 0 0 0.97s
✅ YAML v8r 10 0 0 4.79s
✅ YAML yamllint 10 0 0 0.51s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hmstepanek hmstepanek force-pushed the langchain-str-response-fix branch from 6974e04 to bdb52a7 Compare March 25, 2025 22:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.47%. Comparing base (0c59fe3) to head (21a82c5).

Files with missing lines Patch % Lines
newrelic/hooks/mlmodel_langchain.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
- Coverage   81.48%   81.47%   -0.01%     
==========================================
  Files         204      204              
  Lines       22821    22823       +2     
  Branches     3617     3618       +1     
==========================================
  Hits        18595    18595              
- Misses       3013     3016       +3     
+ Partials     1213     1212       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmstepanek hmstepanek force-pushed the langchain-str-response-fix branch from 7726cf6 to 9da8f9f Compare March 29, 2025 01:06
@hmstepanek hmstepanek marked this pull request as ready for review March 29, 2025 01:10
@hmstepanek hmstepanek requested a review from a team as a code owner March 29, 2025 01:10
@hmstepanek hmstepanek force-pushed the langchain-str-response-fix branch from 9da8f9f to 21a82c5 Compare March 31, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants