Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute check #1311

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add attribute check #1311

wants to merge 10 commits into from

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Feb 25, 2025

This PR adds an attribute check for the GC runtime metrics check.

settings.gc_runtime_metrics is of type GCRuntimeMetricsSettings() and this inherits from Settings()
global_settings() uses TopLevelSettings() which also inherits from Settings()

global_settings may not necessarily have access to the gc_runtime_metrics and these instances result in an attribute error for this enable check.

Copy link

github-actions bot commented Feb 25, 2025

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ PYTHON ruff 1 0 1 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lrafeei lrafeei marked this pull request as ready for review February 25, 2025 18:32
@lrafeei lrafeei requested a review from a team as a code owner February 25, 2025 18:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (eb8d44b) to head (a1bb7a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
- Coverage   81.33%   81.33%   -0.01%     
==========================================
  Files         203      203              
  Lines       22641    22643       +2     
  Branches     3574     3575       +1     
==========================================
+ Hits        18416    18417       +1     
- Misses       3032     3035       +3     
+ Partials     1193     1191       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 3, 2025

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ MARKDOWN markdownlint 19 5 14 0.96s
❌ MARKDOWN markdown-link-check 19 12 89.21s
❌ PYTHON ruff yes yes 1 0.28s
✅ RST rstcheck 2 0 4.36s
✅ RST rstfmt 2 1 0 1.77s
✅ RST rst-lint 2 0 1.14s
✅ YAML prettier 10 1 0 1.09s
✅ YAML v8r 10 0 5.1s
✅ YAML yamllint 10 0 0.64s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot removed the tests-failing label Mar 6, 2025
@mergify mergify bot added the tests-failing label Mar 6, 2025
@mergify mergify bot removed the tests-failing label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants