JDK24 support #2284
Merged
JDK24 support #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
============================================
+ Coverage 70.65% 70.81% +0.15%
- Complexity 10023 10244 +221
============================================
Files 844 844
Lines 40507 41478 +971
Branches 6140 6364 +224
============================================
+ Hits 28619 29371 +752
- Misses 9108 9288 +180
- Partials 2780 2819 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtduffy
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running the agent in JRE 24. Resolves #2241
During our evaluation of Java 24, we did uncover one issue, which was in our instrumentation of
java/lang/ClassLoader. Due to some Java 24 updates to theinitSystemClassLoadermethod, the agent caused a VerifyError in this class because of its resolution of the superclass ofThrowableandException. This is explained in more detail in the updates toPatchedClassWriter.Also, the jms-3 test has been limited to LTS versions <24 because of test dependency ActiveMQ's use of the security manager api (which was removed in JDK24).
(Edit: the AITs tests are expected to fail, because they also need to be configured to run with 24. I have a branch for that
jdk24-supportin the AITs repo, which will be merged after this PR. Here is a GHA of the PR test suite against that branch: https://github.com/newrelic/newrelic-java-agent/actions/runs/14116167431)