Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AI Monitoring instrumentation for AmazonBedrockRuntimeClient.ConverseAsync() #2997

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Feb 18, 2025

Description

Adds AI Monitoring instrumentation for the ConverseAsync() method in AmazonBedrockRuntimeClient. This method became available in AWSSDK.BedrockRuntime v3.7.303.

Supports Text conversations only.

Includes integration tests.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@tippmar-nr tippmar-nr requested a review from a team as a code owner February 18, 2025 21:44
@chynesNR
Copy link
Member

Looks pretty good! This won't create double instrumentation with InvokeModelAsync right?

@tippmar-nr
Copy link
Member Author

Looks pretty good! This won't create double instrumentation with InvokeModelAsync right?

Nope, they are separate APIs

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (9994259) to head (1efc69a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         475      475           
  Lines       30459    30459           
  Branches     3407     3407           
=======================================
+ Hits        25010    25012    +2     
+ Misses       4649     4648    -1     
+ Partials      800      799    -1     
Flag Coverage Δ
Agent 83.14% <ø> (+<0.01%) ⬆️
Profiler 72.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@tippmar-nr tippmar-nr changed the title feat: LLM instrumentation support for AmazonBedrockRuntimeClient.ConverseAsync() feat: AI Monitoring instrumentation for AmazonBedrockRuntimeClient.ConverseAsync() Feb 19, 2025
@tippmar-nr tippmar-nr changed the title feat: AI Monitoring instrumentation for AmazonBedrockRuntimeClient.ConverseAsync() feat: Add AI Monitoring instrumentation for AmazonBedrockRuntimeClient.ConverseAsync() Feb 19, 2025
@tippmar-nr tippmar-nr merged commit cdc2f6c into main Feb 19, 2025
97 checks passed
@tippmar-nr tippmar-nr deleted the feature/bedrock-converse-instrumentation branch February 19, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants