Rename bool union member
#11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C23, `bool` has been changed from a macro defined in `<stdbool.h>`, which
expands to `_Bool`, to a keyword. The `var` union defined in wmgeneral.h
contains a member named `bool`, which is, therefore, not compatible with C23.
The next version of gcc defaults to C23, and so this union member will cause
compilation to fail. Rename it to `boolean`.
Replace `if (cond) { x = 1; } else { x = 0; }` with `x = cond;`
Signed-off-by: Jeremy Sowden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C23,
boolhas been changed from a macro defined in<stdbool.h>, which expands to_Bool, to a keyword. Thevarunion defined in wmgeneral.h contains a member namedbool, which is, therefore, not compatible with C23. The next version of gcc defaults to C23, and so this union member will cause compilation to fail. Rename it toboolean.Replace
if (cond) { x = 1; } else { x = 0; }withx = cond;